opt: fix histogram filtering with infinite upper bound #100763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
mgartner
force-pushed
the
100582-fix-nan-histogram
branch
from
b54760a to
a3b79b5
Compare
michae2
approved these changes
Apr 6, 2023
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @mgartner and @rytaft)
pkg/sql/opt/props/histogram.go line 754 at r1 (raw file):
// to the new bucket. numRange = b.NumRange * rangeAfter / rangeBefore if !math.IsNaN(numRange) {
Does this happen because rangeAfter is NaN? Or Infinity?
|
Previously, michae2 (Michael Erickson) wrote…
It happens when both |
rytaft
approved these changes
Apr 6, 2023
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:
mgartner
added
backport-22.2.x
backport-23.1.x
This commit fixes a bug that caused the filtering a histogram bucket with an infinite upper bound to produce a bucket with a `numRange` of `NaN`. This led to bad query plans because the `NaN` did not reduce the input expression's row count at all. Fixes cockroachdb#100582 Release note (bug fix): A bug has been fixed that caused suboptimal query plans when a table contained infinite values, like `'+Infinity'::DECIMAL`. This bug is present since versions v22.1, and likely earlier. It could also be triggered in rare cases when table statistics forecasts created a forecasted bucket with an infinite value.
mgartner
force-pushed
the
100582-fix-nan-histogram
branch
from
a3b79b5 to
7b8ad4c
Compare
|
TFTRs! bors r+ |
|
Build succeeded: |
This was referenced Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug that caused the filtering a histogram bucket
with an infinite upper bound to produce a bucket with a
numRangeofNaN. This led to bad query plans because theNaNdid not reduce theinput expression's row count at all.
Fixes #100582
Release note (bug fix): A bug has been fixed that caused suboptimal
query plans when a table contained infinite values, like
'+Infinity'::DECIMAL. This bug is present since versions v22.1, andlikely earlier. It could also be triggered in rare cases when table
statistics forecasts created a forecasted bucket with an infinite value.